Skip to content

Solari initial GI #20020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Solari initial GI #20020

wants to merge 13 commits into from
+425 −60

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Jul 7, 2025

Objective

  • Add 1-bounce RT GI

Solution

  • Implement a very very basic version of ReSTIR GI https://d1qx31qr3h6wln.cloudfront.net/publications/ReSTIR%20GI.pdf
  • Pretty much a copy of the ReSTIR DI code, but adjusted for GI.
  • Didn't implement the jacobian resampling, or add more spatial samples, or do anything needed for better quality.
  • Didn't try to improve perf at all yet (it's actually faster than DI though, unfortunately 😅)
  • Didn't spend any time cleaning up the shared abstractions between DI/GI

Showcase

image

@JMS55 JMS55 added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen labels Jul 7, 2025
@JMS55 JMS55 added this to the 0.17 milestone Jul 7, 2025
@JMS55 JMS55 requested review from atlv24, ecoskey and tychedelia and removed request for atlv24 July 7, 2025 20:59
@alice-i-cecile alice-i-cecile added M-Needs-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 8, 2025
alice-i-cecile
alice-i-cecile reviewed Jul 8, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and clear :) I'm not able to give this a full review, but this is a nice diff and the release notes are solid.

atlv24
atlv24 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@atlv24 atlv24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with the understanding that the duplicated code will eventually be cleaned up. im not fully sure why it has to be duplicated in the first place anyways

@JMS55 JMS55 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 8, 2025
@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 8, 2025
@alice-i-cecile
Copy link
Member

This needs a second review; my positive feelings don't count for enough :)

@JMS55
Copy link
Contributor Author

JMS55 commented Jul 8, 2025

Oh thought you approved it 😅

approving with the understanding that the duplicated code will eventually be cleaned up. im not fully sure why it has to be duplicated in the first place anyways

I don't have a good idea of what's truly going to be shared long term. I'm still working on improving things, this is just a very basic implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

@atlv24 atlv24 atlv24 approved these changes

@ecoskey ecoskey Awaiting requested review from ecoskey

@tychedelia tychedelia Awaiting requested review from tychedelia

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible M-Needs-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Rendering
Status: No status
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
3 participants
@JMS55 @alice-i-cecile @atlv24